summaryrefslogtreecommitdiffstats
path: root/freebsd/FreeBSDProcessList.c
Commit message (Collapse)AuthorAgeFilesLines
* Release memory for cmdline when Process_updateCmdline() returns.Ximalas2021-10-031-0/+2
| | | | This closes a nasty memory leak. There is at least another leak looming somewhere when Disk I/O is shown in the header area. That could very well be an issue within libdevstat native to FreeBSD.
* Update license headers to explicitly say GPLv2+Daniel Lange2021-09-221-1/+1
|
* PCP: support for 'dynamic columns' added at runtimeSohaib Mohamed2021-08-131-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Implements support for arbitrary Performance Co-Pilot metrics with per-process instance domains to form new htop columns. The column-to-metric mappings are setup using configuration files which will be documented via man pages as part of a follow-up commit. We provide an initial set of column configurations so as to provide new capabilities to pcp-htop: including configs for containers, open fd counts, scheduler run queue time, tcp/udp bytes/calls sent/recv, delay acct, virtual machine guests, detailed virtual memory, swap. Note there is a change to the configuration file path resolution algorithm introduced for 'dynamic meters'. First, look in any custom PCP_HTOP_DIR location. Then iterate, in priority order, users home directory, then local sysadmins files in /etc/pcp/htop, then readonly configuration files below /usr/share/pcp/htop. This final location becomes the preferred place for our own shipped meter and column files. The Settings file (htoprc) writing code is updated to not using the numeric identifier for dynamic columns. The same strategy used for dynamic meters is used here where we write Dynamic(name) so the name can be setup once more at start. Regular (static) columns writing to htoprc - i.e. numerically indexed - is unchanged.
* FreeBSD: mark the original kernel thread with pid 0 as suchChristian Göttsche2021-07-181-1/+1
|
* FreeBSD: calculate whether to show entry lastChristian Göttsche2021-07-181-2/+2
| | | | Wait until it has been decided what kind of task the entry actually is.
* FreeBSD: skip exe check for kernel threadChristian Göttsche2021-07-181-6/+5
| | | | | Kernel threads do not have an executable and the check can result in garbage values as unprivileged user.
* Add ProcessList_isCPUonlineChristian Göttsche2021-07-181-0/+9
|
* Rework CPU countingChristian Göttsche2021-07-181-4/+6
| | | | | | | | | | | Currently htop does not support offline CPUs and hot-swapping, e.g. via echo 0 > /sys/devices/system/cpu/cpu2/online Split the current single cpuCount variable into activeCPUs and existingCPUs. Supersedes: #650 Related: #580
* Code indentationBenny Baumann2021-07-151-2/+2
|
* Add a new DynamicMeter class for runtime Meter extensionNathan Scott2021-07-071-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit is based on exploratory work by Sohaib Mohamed. The end goal is two-fold - to support addition of Meters we build via configuration files for both the PCP platform and for scripts ( https://github.com/htop-dev/htop/issues/526 ) Here, we focus on generic code and the PCP support. A new class DynamicMeter is introduced - it uses the special case 'param' field handling that previously was used only by the CPUMeter, such that every runtime-configured Meter is given a unique identifier. Unlike with the CPUMeter this is used internally only. When reading/writing to htoprc instead of CPU(N) - where N is an integer param (CPU number) - we use the string name for each meter. For example, if we have a configuration for a DynamicMeter for some Redis metrics, we might read and write "Dynamic(redis)". This identifier is subsequently matched (back) up to the configuration file so we're able to re-create arbitrary user configurations. The PCP platform configuration file format is fairly simple. We expand configs from several directories, including the users homedir alongside htoprc (below htop/meters/) and also /etc/pcp/htop/meters. The format will be described via a new pcp-htop(5) man page, but its basically ini-style and each Meter has one or more metric expressions associated, as well as specifications for labels, color and so on via a dot separated notation for individual metrics within the Meter. A few initial sample configuration files are provided below ./pcp/meters that give the general idea. The PCP "derived" metric specification - see pmRegisterDerived(3) - is used as the syntax for specifying metrics in PCP DynamicMeters.
* FreeBSD: Implement CWD columnBenny Baumann2021-05-251-0/+24
|
* FreeBSD: add EXE and COMM columns and use merged command line helpersChristian Göttsche2021-05-231-17/+38
|
* Call makeCommandStr on all platformsBenny Baumann2021-05-231-0/+4
|
* Move kernel/userland thread handling to platform-independent implementationBenny Baumann2021-05-231-1/+2
|
* Rename cmdlineBasenameOffset to cmdlineBasenameEnd to properly indicate the ↵Benny Baumann2021-05-231-2/+2
| | | | fields purpose
* Rename basenameOffset to cmdlineBasenameOffsetBenny Baumann2021-05-231-2/+2
|
* Rename command line field from comm to cmdlineBenny Baumann2021-05-231-3/+3
|
* platform-dependent files included relative to main source directorymayurdahibhate2021-05-101-1/+1
|
* FreeBSD: silence unsigned integer underflowChristian Göttsche2021-04-141-1/+1
| | | | | | | | | freebsd/FreeBSDProcessList.c:252:47: runtime error: unsigned integer overflow: 0 - 1 cannot be represented in type 'unsigned int' #0 0x397c32 in FreeBSDProcessList_scanCPU /root/workspace/htop/htop/freebsd/FreeBSDProcessList.c:252:47 #1 0x38fe76 in ProcessList_goThroughEntries /root/workspace/htop/htop/freebsd/FreeBSDProcessList.c:438:4 #2 0x35ef9a in ProcessList_scan /root/workspace/htop/htop/ProcessList.c:618:4 #3 0x31ee9e in main /root/workspace/htop/htop/htop.c:468:4 #4 0x26bbcf in _start /usr/src/lib/csu/amd64/crt1.c:76:7
* Rework TTY columnChristian Göttsche2021-04-141-78/+9
| | | | | | | | | | * Rename internal identifier from TTY_NR to just TTY * Unify column header on platforms * Use devname(3) on BSD derivate to show the actual terminal, simplifies current FreeBSD implementation. * Use 'unsigned long int' as id type, to fit dev_t on Linux. Only on Solaris the terminal path is not yet resolved.
* FreeBSD: improve actual processor calculation logicAlexander Nedotsukov2021-03-301-1/+5
|
* Use unsigned types for CPU counts and associated variablesChristian Göttsche2021-03-191-5/+5
|
* Merge pull request #436 from cgzones/freebsdGraham Inggs2021-03-181-2/+64
|\ | | | | | | FreeBSD: add support for CPU frequency and temperature Tested on two physical systems running FreeBSD 12.1
| * FreeBSD: add support for CPU frequency and temperatureChristian Göttsche2021-02-051-2/+64
| |
* | Fix include file ordering of generic headersNathan Scott2021-03-041-1/+1
| |
* | Move generic (shared) code into its own sub-directoryNathan Scott2021-03-041-1/+1
|/ | | | | | | | Code that is shared across some (but not all) platforms is moved into a 'generic' home. Makefile.am cleanups to match plus some minor alphabetic reordering/formatting. As discussed in https://github.com/htop-dev/htop/pull/553
* FreeBSD: drop minflt and implement majfltChristian Göttsche2021-01-301-0/+2
|
* FreeBSD: drop unused idle thread codeChristian Göttsche2021-01-301-11/+0
|
* FreeBSD: populate processor fieldChristian Göttsche2021-01-301-0/+2
|
* FreeBSD: drop unused jail_errmsg variableChristian Göttsche2021-01-301-32/+16
|
* FreeBSD: simplify kernel thread logicChristian Göttsche2021-01-301-5/+1
|
* FreeBSD: drop unused ProcessList fieldsChristian Göttsche2021-01-301-2/+2
|
* FreeBSD: miscChristian Göttsche2021-01-301-3/+3
|
* kfreeBSD: include config.h for _GNU_SOURCE (part 2)Christian Göttsche2021-01-121-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | strcasestr(3) is a GNU extension and when compiling freebsd/Platform.c on kfreebsd for Debian <string.h> is included before we define _GNU_SOURCE, so the function is not available. In file included from ./Object.h:16, from ./ListItem.h:12, from ./Meter.h:16, from ./Header.h:10, from ./Action.h:15, from freebsd/Platform.h:13, from freebsd/Platform.c:8: ./XUtils.h: In function ‘String_contains_i’: ./XUtils.h:43:11: warning: implicit declaration of function ‘strcasestr’; did you mean ‘strcasecmp’? [-Wimplicit-function-declaration] 43 | return strcasestr(s1, s2) != NULL; | ^~~~~~~~~~ | strcasecmp ./XUtils.h:43:30: warning: comparison between pointer and integer 43 | return strcasestr(s1, s2) != NULL; | ^~ In file included from ./Object.h:16, from ./ProcessList.h:16, from freebsd/FreeBSDProcessList.h:15, from freebsd/FreeBSDProcessList.c:8: ./XUtils.h: In function ‘String_contains_i’: ./XUtils.h:43:11: warning: implicit declaration of function ‘strcasestr’; did you mean ‘strcasecmp’? [-Wimplicit-function-declaration] 43 | return strcasestr(s1, s2) != NULL; | ^~~~~~~~~~ | strcasecmp ./XUtils.h:43:30: warning: comparison between pointer and integer 43 | return strcasestr(s1, s2) != NULL; | ^~
* Linux: use correct column alignment for wide fieldsChristian Göttsche2021-01-111-1/+1
| | | | | | | This affects: - PROC_COMM, PROC_EXE and CWD on Linux - JAIL on FreeBSD and DragonFlyBSD - ZONE on Solaris
* Drop usage of formatted error messages from <err.h>Christian Göttsche2021-01-071-2/+1
| | | | | | | They do not clean up the ncurses environment, leaving the terminal in a broken state. Also drop bare usage of exit(3).
* Drop redundant sys/dirent.h includeGraham Inggs2020-12-111-1/+0
| | | sys/dirent.h is included by dirent.h in FreeBSD, and does not exist in Debian GNU/kFreeBSD
* Cull the definitions of pageSize and pageSizeKB from CRT.cNathan Scott2020-12-101-9/+6
| | | | | | | | | | | | | | | By storing the per-process m_resident and m_virt values in the form htop wants to display them in (KB, not pages), we no longer need to have definitions of pageSize and pageSizeKB in the common CRT code. These variables were never really CRT (i.e. display) related in the first place. It turns out the darwin platform code doesn't need to use these at all (the process values are extracted from the kernel in bytes not pages) and the other platforms can each use their own local pagesize variables, in more appropriate locations. Some platforms were actually already doing this, so this change is removing duplication of logic and variables there.
* Drop unused global ProcessList memory fieldsNathan Scott2020-11-271-8/+0
| | | | | | | | | | The global ProcessList structure contains a couple of unused fields. 'sharedMem' has never been used by any Meter, since its not been anything other than zero in Linux /proc/meminfo for many, many years. The freeMem field is only used in the usedMem calculation, so it can reside on the stack like some other memory variables used within-calculations-only and not exposed to the user via a Meter.
* Simplify code flow by inlining declarations where they are usedBenny Baumann2020-11-221-14/+7
| | | | Note that xStrdup always returns non-NULL, thus the one error case cannot be reached.
* No need to check for change when no action is requiredBenny Baumann2020-11-221-4/+2
|
* Simplify page size related calculationsChristian Göttsche2020-11-211-1/+1
|
* Rename virtual memory column from M_SIZE to M_VIRTChristian Göttsche2020-11-211-1/+1
| | | | Closes: #325
* IWYU update (FreeBSD)Christian Goettsche2020-11-191-5/+13
|
* Embracing branchesBenny Baumann2020-11-021-12/+24
|
* Spacing around operatorsBenny Baumann2020-11-021-8/+8
|
* Whitespace and indentation issuesBenny Baumann2020-11-021-21/+21
|
* Spacing after keywords (if)Benny Baumann2020-11-021-2/+2
|
* Add compat wrapper for fstatatChristian Göttsche2020-10-291-2/+3
|
* FreeBSD: update ProcessChristian Göttsche2020-10-291-3/+2
|

© 2014-2024 Faster IT GmbH | imprint | privacy policy