summaryrefslogtreecommitdiffstats
path: root/CRT.c
Commit message (Collapse)AuthorAgeFilesLines
* Update license headers to explicitly say GPLv2+Daniel Lange2021-09-221-1/+1
|
* Use libunwind for printing backtraceChristian Göttsche2021-09-211-9/+68
|
* CRT: close backup stderr file after resetChristian Göttsche2021-09-101-0/+2
| | | | | Close the backup file descriptor of original stderr once it has been restored at stderr.
* NetBSD: silence dropping const qualifier on define_key(3)Christian Göttsche2021-09-031-0/+8
| | | | | | On NetBSD define_key(3) has the prototype int define_key(char *sequence, int key_symbol);
* NetBSD: color process state P as runningChristian Göttsche2021-09-031-6/+6
| | | | | | On NetBSD state 'R' means runnable not running. Improve the color identifier name accordingly.
* Shorten crash output to fit on screenChristian Göttsche2021-08-261-16/+9
|
* IWYU updateChristian Göttsche2021-08-251-0/+1
|
* Reset the signal handlers at program exitChristian Göttsche2021-08-161-15/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The signal handler will access the Settings struct, which gets freed at normal program finalization. When using leak sanitizers with ASAN_OPTIONS=abort_on_error=1, which runs after program termination, any leak causes SIGABRT to be raised, calling the crash handler, which will derefernce the freed Settings. ==44741==ERROR: AddressSanitizer: heap-use-after-free on address 0x60d000000080 at pc 0x0000005680df bp 0x7fffe335e960 sp 0x7fffe335e958 READ of size 8 at 0x60d000000080 thread T0 #0 0x5680de in Settings_write /home/christian/Coding/workspaces/htop/Settings.c:329:26 #1 0x4f77b7 in CRT_handleSIGSEGV /home/christian/Coding/workspaces/htop/CRT.c:1020:4 #2 0x7f8a1120c13f (/lib/x86_64-linux-gnu/libpthread.so.0+0x1413f) #3 0x7f8a11042ce0 in __libc_signal_restore_set signal/../sysdeps/unix/sysv/linux/internal-signals.h:86:3 #4 0x7f8a11042ce0 in raise signal/../sysdeps/unix/sysv/linux/raise.c:48:3 #5 0x7f8a1102c536 in abort stdlib/abort.c:79:7 #6 0x4c3db6 in __sanitizer::Abort() (/home/christian/Coding/workspaces/htop/htop+0x4c3db6) #7 0x4c2090 in __sanitizer::Die() (/home/christian/Coding/workspaces/htop/htop+0x4c2090) #8 0x4d0a17 in __lsan::HandleLeaks() (/home/christian/Coding/workspaces/htop/htop+0x4d0a17) #9 0x4cd950 in __lsan::DoLeakCheck() (/home/christian/Coding/workspaces/htop/htop+0x4cd950) #10 0x7f8a110454d6 in __run_exit_handlers stdlib/exit.c:108:8 #11 0x7f8a11045679 in exit stdlib/exit.c:139:3 #12 0x7f8a1102dd10 in __libc_start_main csu/../csu/libc-start.c:342:3 #13 0x428a19 in _start (/home/christian/Coding/workspaces/htop/htop+0x428a19) 0x60d000000080 is located 64 bytes inside of 144-byte region [0x60d000000040,0x60d0000000d0) freed by thread T0 here: #0 0x4a4f72 in free (/home/christian/Coding/workspaces/htop/htop+0x4a4f72) #1 0x566693 in Settings_delete /home/christian/Coding/workspaces/htop/Settings.c:32:4 #2 0x4ede10 in CommandLine_run /home/christian/Coding/workspaces/htop/CommandLine.c:393:4 #3 0x4d6f32 in main /home/christian/Coding/workspaces/htop/htop.c:15:11 #4 0x7f8a1102dd09 in __libc_start_main csu/../csu/libc-start.c:308:16 previously allocated by thread T0 here: #0 0x4a5372 in __interceptor_calloc (/home/christian/Coding/workspaces/htop/htop+0x4a5372) #1 0x57f61a in xCalloc /home/christian/Coding/workspaces/htop/XUtils.c:55:17 #2 0x5688a6 in Settings_new /home/christian/Coding/workspaces/htop/Settings.c:392:21 #3 0x4ecb57 in CommandLine_run /home/christian/Coding/workspaces/htop/CommandLine.c:303:25 #4 0x4d6f32 in main /home/christian/Coding/workspaces/htop/htop.c:15:11 #5 0x7f8a1102dd09 in __libc_start_main csu/../csu/libc-start.c:308:16 SUMMARY: AddressSanitizer: heap-use-after-free /home/christian/Coding/workspaces/htop/Settings.c:329:26 in Settings_write
* Correct grammatical error in crash informationChristian Göttsche2021-08-101-1/+1
| | | | Spotted by @natoscott
* netbsd: Support curses libraries without ncurses mouse supportnia2021-07-151-0/+4
| | | | | | | | | | | | This adds a configure check for the ncurses getmouse() function and disables mouse-related code paths when mouse support is not present in the curses library. This is necessary for stable versions of NetBSD's libcurses, the development version has stub mouse functions for compatibility with ncurses. Signed-off-by: Nia Alarie <nia@NetBSD.org>
* Pointer indication aligned to typenameBenny Baumann2021-07-151-1/+1
|
* Add SIGINT handlerBenny Baumann2021-07-131-0/+1
| | | | | | | This SIGINT handler is installed on top of an optional handler that some curses/ncurses implementations provide. This ensures the curser is properly reset when hitting Ctrl+C.
* Add a new DynamicMeter class for runtime Meter extensionNathan Scott2021-07-071-1/+55
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit is based on exploratory work by Sohaib Mohamed. The end goal is two-fold - to support addition of Meters we build via configuration files for both the PCP platform and for scripts ( https://github.com/htop-dev/htop/issues/526 ) Here, we focus on generic code and the PCP support. A new class DynamicMeter is introduced - it uses the special case 'param' field handling that previously was used only by the CPUMeter, such that every runtime-configured Meter is given a unique identifier. Unlike with the CPUMeter this is used internally only. When reading/writing to htoprc instead of CPU(N) - where N is an integer param (CPU number) - we use the string name for each meter. For example, if we have a configuration for a DynamicMeter for some Redis metrics, we might read and write "Dynamic(redis)". This identifier is subsequently matched (back) up to the configuration file so we're able to re-create arbitrary user configurations. The PCP platform configuration file format is fairly simple. We expand configs from several directories, including the users homedir alongside htoprc (below htop/meters/) and also /etc/pcp/htop/meters. The format will be described via a new pcp-htop(5) man page, but its basically ini-style and each Meter has one or more metric expressions associated, as well as specifications for labels, color and so on via a dot separated notation for individual metrics within the Meter. A few initial sample configuration files are provided below ./pcp/meters that give the general idea. The PCP "derived" metric specification - see pmRegisterDerived(3) - is used as the syntax for specifying metrics in PCP DynamicMeters.
* Use the PACKAGE macro rather than htop directly, for overridingNathan Scott2021-06-131-6/+6
| | | | | | Allow other projects (PCP) to be able to ship an htop binary which uses the custom name (pcp-htop) in several diagnostics so that its clear which (if any!) binary failed.
* Use STDERR_FILENO instead of magic numberChristian Göttsche2021-05-161-1/+1
|
* Print current settings on crashChristian Göttsche2021-05-161-0/+8
|
* Add read-only optionChristian Göttsche2021-04-141-0/+6
| | | | | Add command line option to disable all system and process changing features.
* TaskMeter: always show number of threadsChristian Göttsche2021-03-311-0/+6
| | | | | | | | | | | Always show the number of kernel and userland threads, even when they are disabled to not be shown in the process list. The data is already available and might improve understanding the system utilization. Use a shadow color in case the kind of thread is hidden, else the normal meter one.
* Use `#if defined()` syntax when `#elif defined()` is presentBenny Baumann2021-03-211-1/+1
| | | | | | | This prefers the `#if defined()` syntax over the `#ifdef` variant whenever there's also a `#elif defined()` clause, thus making the multiple branching structure more obvious and the overall use more consistent.
* Linux: individually show shared memoryChristian Göttsche2021-03-151-0/+6
| | | | | | | | Shmem: Total memory used by shared memory (shmem) and tmpfs Source: https://www.kernel.org/doc/Documentation/filesystems/proc.txt Closes: #556
* Use ATTR_UNUSED instead of void castingChristian Göttsche2021-03-021-2/+1
|
* Remove setuid supportBenny Baumann2021-02-171-31/+0
| | | | | | | This support was rarely ever used and has been disabled by default for some time. As far as the developer team is aware there's no distribution that activated this feature in their packages by default.
* Cache stderr to be able to print assert messagesChristian Göttsche2021-02-051-0/+93
|
* Remove unused key definitionsDaniel Lange2021-02-011-3/+0
|
* Fix Shift+Function key on Qt-based terminalsBenBE2021-02-011-0/+4
| | | Fixes #508.
* Do not call exit(3) in signal handlerChristian Göttsche2021-01-291-1/+1
| | | | Call safe _exit(2) instead
* Pass Settings to CRT_initChristian Göttsche2021-01-271-6/+4
| | | | Resolve todo
* Linux: individual huge page values in the huge page meterDavid Zarzycki2021-01-191-0/+24
|
* Linux: Add SwapCached to the swap meterDavid Zarzycki2021-01-111-0/+6
| | | | | | | According to the Linux kernel documentation, "SwapCached" tracks "memory that once was swapped out, is swapped back in but still also is in the swapfile (if memory is needed it doesn't need to be swapped out AGAIN because it is already in the swapfile. This saves I/O)."
* Fix white text in the Light Terminal colour schemeV2021-01-111-7/+12
|
* Merge branch 'light_color' of cgzones/htopDaniel Lange2021-01-081-21/+21
|\
| * Revert color change on LightTerminalChristian Göttsche2021-01-081-21/+21
| | | | | | | | | | | | | | | | | | Partially revert 4b14ab9789eee004daab8594ac00a113c18af060 ColorPair(Black,Black) is not actually black on black, but due to adjustments in CRT_setColors() black on default-background-color. Thanks to V for reporting.
* | Refactor crash handler message to avoid embedded directiveChristian Göttsche2021-01-081-3/+11
|/ | | | | | | | | | | | | | | | | | | | | | CRT.c:821:2: error: embedding a directive within macro arguments has undefined behavior [-Werror,-Wembedded-directive] #ifdef HAVE_EXECINFO_H ^ CRT.c:823:2: error: embedding a directive within macro arguments has undefined behavior [-Werror,-Wembedded-directive] #endif ^ CRT.c:858:2: error: embedding a directive within macro arguments has undefined behavior [-Werror,-Wembedded-directive] #ifdef HTOP_DARWIN ^ CRT.c:862:2: error: embedding a directive within macro arguments has undefined behavior [-Werror,-Wembedded-directive] #endif ^ CRT.c:864:2: error: embedding a directive within macro arguments has undefined behavior [-Werror,-Wembedded-directive] #ifdef HTOP_DARWIN ^ CRT.c:868:2: error: embedding a directive within macro arguments has undefined behavior [-Werror,-Wembedded-directive] #endif ^
* Show arrow indicating order of sorted process columnChristian Göttsche2021-01-071-0/+4
|
* CRT: add METER_VALUE_ERROR and adjust some METER_VALUE_WARN colorsChristian Göttsche2020-12-261-2/+8
|
* Enable going back to previous search matches (Shift-F3)Daniel Lange2020-12-251-0/+1
|
* Misc CRT cleanupChristian Göttsche2020-12-141-26/+22
|
* Cull the definitions of pageSize and pageSizeKB from CRT.cNathan Scott2020-12-101-8/+0
| | | | | | | | | | | | | | | By storing the per-process m_resident and m_virt values in the form htop wants to display them in (KB, not pages), we no longer need to have definitions of pageSize and pageSizeKB in the common CRT code. These variables were never really CRT (i.e. display) related in the first place. It turns out the darwin platform code doesn't need to use these at all (the process values are extracted from the kernel in bytes not pages) and the other platforms can each use their own local pagesize variables, in more appropriate locations. Some platforms were actually already doing this, so this change is removing duplication of logic and variables there.
* IWYU updateChristian Göttsche2020-12-061-1/+0
|
* Hide degree character without wide ncurses supportChristian Göttsche2020-12-051-1/+1
|
* Resolve conversion from int to shortChristian Göttsche2020-12-051-7/+5
|
* Set locale only once and do not override it laterChristian Göttsche2020-12-021-3/+0
|
* Compare indices not index with pairChristian Göttsche2020-12-021-1/+1
| | | | | | Fixes always true condition. Found by LGTM.com
* Use enum element name instead of magic numberChristian Göttsche2020-12-021-1/+2
|
* Add support to change numeric options in settings screenChristian Göttsche2020-11-251-6/+6
| | | | Like delay or highlightDelaySecs
* Improving Command display/sortNarendran Gopalakrishnan2020-11-241-0/+18
|
* Show CPU temperature in CPU meterChristian Göttsche2020-11-161-0/+19
| | | | | Show the CPU temperature in the CPU meter, like CPU frequency, instead of using an extra Meter.
* Fix whitespace before comma in the new color definitionsDaniel Lange2020-11-161-10/+10
|
* Merge branch 'hili-new-old' of adsr/htop into highlight-new-old-processesDaniel Lange2020-11-161-0/+12
|\
| * Highlight new and old processes (#74)Adam Saponara2020-10-301-0/+12
| |

© 2014-2024 Faster IT GmbH | imprint | privacy policy