summaryrefslogtreecommitdiffstats
path: root/unsupported
diff options
context:
space:
mode:
authorNathan Scott <nathans@redhat.com>2023-09-01 09:34:46 +1000
committerNathan Scott <nathans@redhat.com>2023-09-04 08:59:41 +1000
commit66c0b19ed6fec2afd4ed381665274fa83c67660e (patch)
treee8420e98aa4d5fb633cbb432babfa86d3dcdaf37 /unsupported
parent9392e1d596dd2bed165c8cb522a0c9fd5fede66d (diff)
Correct pid_t type return from Platform_getMaxPid function
Coverity scanning shows we end up passing an integer into the Row_setPidColumnWidth routine which requires a pid_t - update each platform to return the correct type (and never return -1 as a failure code, this was being ignored).
Diffstat (limited to 'unsupported')
-rw-r--r--unsupported/Platform.c4
-rw-r--r--unsupported/Platform.h5
2 files changed, 6 insertions, 3 deletions
diff --git a/unsupported/Platform.c b/unsupported/Platform.c
index df7f3600..dbfddd91 100644
--- a/unsupported/Platform.c
+++ b/unsupported/Platform.c
@@ -102,8 +102,8 @@ void Platform_getLoadAverage(double* one, double* five, double* fifteen) {
*fifteen = 0;
}
-int Platform_getMaxPid(void) {
- return 1;
+pid_t Platform_getMaxPid(void) {
+ return INT_MAX;
}
double Platform_setCPUValues(Meter* this, unsigned int cpu) {
diff --git a/unsupported/Platform.h b/unsupported/Platform.h
index 8e08dc23..c4cd06a0 100644
--- a/unsupported/Platform.h
+++ b/unsupported/Platform.h
@@ -8,6 +8,9 @@ Released under the GNU GPLv2+, see the COPYING file
in the source distribution for its full text.
*/
+#include <stdbool.h>
+#include <sys/types.h>
+
#include "Action.h"
#include "BatteryMeter.h"
#include "DiskIOMeter.h"
@@ -40,7 +43,7 @@ int Platform_getUptime(void);
void Platform_getLoadAverage(double* one, double* five, double* fifteen);
-int Platform_getMaxPid(void);
+pid_t Platform_getMaxPid(void);
double Platform_setCPUValues(Meter* this, unsigned int cpu);

© 2014-2024 Faster IT GmbH | imprint | privacy policy