summaryrefslogtreecommitdiffstats
path: root/linux/LinuxProcessList.c
diff options
context:
space:
mode:
authorChristian Göttsche <cgzones@googlemail.com>2021-04-26 17:57:47 +0200
committercgzones <cgzones@googlemail.com>2021-04-26 18:02:58 +0200
commit323d7e73aa1cc13b3a0870530e8fbd27102259ec (patch)
tree64d494167e56c824fec228c95ef2a142f0b0dc9e /linux/LinuxProcessList.c
parentb41e4d9c546e95fb308db3308848d7dddb4d98cf (diff)
Linux: update IO fields
- fix header width of IO_READ_RATE - save data in bytes (not kilobytes) to better compute rate - fix rate data: multiply with 1000 to compensate time difference in milliseconds - rename unit less variable now into realtimeMs - use Process_printBytes(..., data * pageSize, ...) instead of Process_printKBytes(..., data * pageSizeKB, ...) to avoid wrapper
Diffstat (limited to 'linux/LinuxProcessList.c')
-rw-r--r--linux/LinuxProcessList.c26
1 files changed, 13 insertions, 13 deletions
diff --git a/linux/LinuxProcessList.c b/linux/LinuxProcessList.c
index 55a3b46f..7a118d77 100644
--- a/linux/LinuxProcessList.c
+++ b/linux/LinuxProcessList.c
@@ -398,7 +398,7 @@ static bool LinuxProcessList_statProcessDir(Process* process, openat_arg_t procF
return true;
}
-static void LinuxProcessList_readIoFile(LinuxProcess* process, openat_arg_t procFd, unsigned long long now) {
+static void LinuxProcessList_readIoFile(LinuxProcess* process, openat_arg_t procFd, unsigned long long realtimeMs) {
char buffer[1024];
ssize_t r = xReadfileat(procFd, "io", buffer, sizeof(buffer));
if (r < 0) {
@@ -411,7 +411,7 @@ static void LinuxProcessList_readIoFile(LinuxProcess* process, openat_arg_t proc
process->io_read_bytes = ULLONG_MAX;
process->io_write_bytes = ULLONG_MAX;
process->io_cancelled_write_bytes = ULLONG_MAX;
- process->io_last_scan_time = now;
+ process->io_last_scan_time_ms = realtimeMs;
return;
}
@@ -423,18 +423,18 @@ static void LinuxProcessList_readIoFile(LinuxProcess* process, openat_arg_t proc
switch (line[0]) {
case 'r':
if (line[1] == 'c' && String_startsWith(line + 2, "har: ")) {
- process->io_rchar = strtoull(line + 7, NULL, 10) / ONE_K;
+ process->io_rchar = strtoull(line + 7, NULL, 10);
} else if (String_startsWith(line + 1, "ead_bytes: ")) {
- process->io_read_bytes = strtoull(line + 12, NULL, 10) / ONE_K;
- process->io_rate_read_bps = ONE_K * (process->io_read_bytes - last_read) / (now - process->io_last_scan_time);
+ process->io_read_bytes = strtoull(line + 12, NULL, 10);
+ process->io_rate_read_bps = (process->io_read_bytes - last_read) * /*ms to s*/1000 / (realtimeMs - process->io_last_scan_time_ms);
}
break;
case 'w':
if (line[1] == 'c' && String_startsWith(line + 2, "har: ")) {
- process->io_wchar = strtoull(line + 7, NULL, 10) / ONE_K;
+ process->io_wchar = strtoull(line + 7, NULL, 10);
} else if (String_startsWith(line + 1, "rite_bytes: ")) {
- process->io_write_bytes = strtoull(line + 13, NULL, 10) / ONE_K;
- process->io_rate_write_bps = ONE_K * (process->io_write_bytes - last_write) / (now - process->io_last_scan_time);
+ process->io_write_bytes = strtoull(line + 13, NULL, 10);
+ process->io_rate_write_bps = (process->io_write_bytes - last_write) * /*ms to s*/1000 / (realtimeMs - process->io_last_scan_time_ms);
}
break;
case 's':
@@ -446,12 +446,12 @@ static void LinuxProcessList_readIoFile(LinuxProcess* process, openat_arg_t proc
break;
case 'c':
if (String_startsWith(line + 1, "ancelled_write_bytes: ")) {
- process->io_cancelled_write_bytes = strtoull(line + 23, NULL, 10) / ONE_K;
+ process->io_cancelled_write_bytes = strtoull(line + 23, NULL, 10);
}
}
}
- process->io_last_scan_time = now;
+ process->io_last_scan_time_ms = realtimeMs;
}
typedef struct LibraryData_ {
@@ -594,7 +594,7 @@ static uint64_t LinuxProcessList_calcLibSize(openat_arg_t procFd) {
return total_size / pageSize;
}
-static bool LinuxProcessList_readStatmFile(LinuxProcess* process, openat_arg_t procFd, bool performLookup, unsigned long long now) {
+static bool LinuxProcessList_readStatmFile(LinuxProcess* process, openat_arg_t procFd, bool performLookup, unsigned long long realtimeMs) {
FILE* statmfile = fopenat(procFd, "statm", "r");
if (!statmfile)
return false;
@@ -618,12 +618,12 @@ static bool LinuxProcessList_readStatmFile(LinuxProcess* process, openat_arg_t p
process->m_lrs = tmp_m_lrs;
} else if (performLookup) {
// Check if we really should recalculate the M_LRS value for this process
- uint64_t passedTimeInMs = now - process->last_mlrs_calctime;
+ uint64_t passedTimeInMs = realtimeMs - process->last_mlrs_calctime;
uint64_t recheck = ((uint64_t)rand()) % 2048;
if(passedTimeInMs > 2000 || passedTimeInMs > recheck) {
- process->last_mlrs_calctime = now;
+ process->last_mlrs_calctime = realtimeMs;
process->m_lrs = LinuxProcessList_calcLibSize(procFd);
}
} else {

© 2014-2024 Faster IT GmbH | imprint | privacy policy