summaryrefslogtreecommitdiffstats
path: root/darwin/DarwinProcess.c
diff options
context:
space:
mode:
authorAlexander Momchilov <alexandermomchilov@gmail.com>2020-12-08 23:12:44 -0500
committercgzones <cgzones@googlemail.com>2020-12-19 21:30:39 +0100
commit67ccd6b909d28ab84c77acecdfee927337489cc2 (patch)
tree25c9c86935167f733356a387fdc6656a0aaef292 /darwin/DarwinProcess.c
parentf614b8a19fe92cd13862605c16d69aa23c8b9bd1 (diff)
Unhardcode tick-to-ms conversion
Division by 100000.0 worked because `sysconf(_SC_CLK_TCK)` happened to be 100. By unhardcoding: 1) It becomes more clear what this 100000.0 figure comes from. 2) It protects against bugs in the case `sysconf(_SC_CLK_TCK)` ever changes.
Diffstat (limited to 'darwin/DarwinProcess.c')
-rw-r--r--darwin/DarwinProcess.c22
1 files changed, 10 insertions, 12 deletions
diff --git a/darwin/DarwinProcess.c b/darwin/DarwinProcess.c
index 94bb193e..15eff08c 100644
--- a/darwin/DarwinProcess.c
+++ b/darwin/DarwinProcess.c
@@ -292,23 +292,21 @@ void DarwinProcess_setFromKInfoProc(Process* proc, const struct kinfo_proc* ps,
proc->updated = true;
}
-void DarwinProcess_setFromLibprocPidinfo(DarwinProcess* proc, DarwinProcessList* dpl) {
+void DarwinProcess_setFromLibprocPidinfo(DarwinProcess* proc, DarwinProcessList* dpl, double time_interval) {
struct proc_taskinfo pti;
if (sizeof(pti) == proc_pidinfo(proc->super.pid, PROC_PIDTASKINFO, 0, &pti, sizeof(pti))) {
- if (0 != proc->utime || 0 != proc->stime) {
- uint64_t diff = (pti.pti_total_system - proc->stime)
- + (pti.pti_total_user - proc->utime);
-
- proc->super.percent_cpu = (double)diff * (double)dpl->super.cpuCount * Platform_timebaseToNS
- / ((double)dpl->global_diff * 100000.0);
-
-// fprintf(stderr, "%f %llu %llu %llu %llu %llu\n", proc->super.percent_cpu,
-// proc->stime, proc->utime, pti.pti_total_system, pti.pti_total_user, dpl->global_diff);
-// exit(7);
+ uint64_t total_existing_time = proc->stime + proc->utime;
+ uint64_t total_current_time = pti.pti_total_system + pti.pti_total_user;
+
+ if (total_existing_time && 1e-6 < time_interval) {
+ uint64_t total_time_diff = total_current_time - total_existing_time;
+ proc->super.percent_cpu = ((double)total_time_diff / time_interval) * 100.0;
+ } else {
+ proc->super.percent_cpu = 0.0;
}
- proc->super.time = (pti.pti_total_system + pti.pti_total_user) / 10000000;
+ proc->super.time = total_current_time / 10000000;
proc->super.nlwp = pti.pti_threadnum;
proc->super.m_virt = pti.pti_virtual_size / ONE_K;
proc->super.m_resident = pti.pti_resident_size / ONE_K;

© 2014-2024 Faster IT GmbH | imprint | privacy policy