diff options
| author | Explorer09 <explorer09@gmail.com> | 2016-05-04 13:39:26 +0800 |
|---|---|---|
| committer | Explorer09 <explorer09@gmail.com> | 2016-05-04 13:39:26 +0800 |
| commit | 9dea20e06847f930920406e6de539db32e2644e0 (patch) | |
| tree | 9fa1d0fcf5d166ad0b8fddb74ba541b0252d1727 /TasksMeter.c | |
| parent | 2ea4bee66dfe496ee649ecb81245b70554774975 (diff) | |
Rename Meter.setValues() functions to updateValues()
Rationale (copied from htop issue #471):
The function name "setValues" is misleading. For most OOP (object-
oriented programming) contexts, setXXX functions mean they will change
some member variables of an object into something specified in
function arguments. But in the *Meter_setValues() case, the new values
are not from the arguments, but from a hard-coded source. The caller
is not supposed to change the values[] to anything it likes, but
rather to "update" the values from the source. Hence, updateValues is
a better name for this family of functions.
Diffstat (limited to 'TasksMeter.c')
| -rw-r--r-- | TasksMeter.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/TasksMeter.c b/TasksMeter.c index dc057188..78a14683 100644 --- a/TasksMeter.c +++ b/TasksMeter.c @@ -18,7 +18,7 @@ int TasksMeter_attributes[] = { CPU_KERNEL, PROCESS_THREAD, PROCESS, TASKS_RUNNING }; -static void TasksMeter_setValues(Meter* this, char* buffer, int len) { +static void TasksMeter_updateValues(Meter* this, char* buffer, int len) { ProcessList* pl = this->pl; this->values[0] = pl->kernelThreads; this->values[1] = pl->userlandThreads; @@ -72,7 +72,7 @@ MeterClass TasksMeter_class = { .delete = Meter_delete, .display = TasksMeter_display, }, - .setValues = TasksMeter_setValues, + .updateValues = TasksMeter_updateValues, .defaultMode = TEXT_METERMODE, .maxItems = 4, .total = 100.0, |