diff options
author | Christian Göttsche <cgzones@googlemail.com> | 2021-04-14 20:47:42 +0200 |
---|---|---|
committer | cgzones <cgzones@googlemail.com> | 2021-04-26 17:51:45 +0200 |
commit | 436808ff99d7b7e6f5d6e8f3127d9d03f6295f98 (patch) | |
tree | 46610957022066f7da0170c1edcc5991435d5400 /DiskIOMeter.c | |
parent | 099dab88be5a7a1c9207e7bc7116618b7108f851 (diff) |
Use RichString_appendnAscii where possible
`RichString_appendnAscii()` avoids a `strlen(3)` call over
` RichString_appendAscii()`.
Use the former where the length is available from a previous checked
`snprintf(3)` call.
Keep `RichString_appendAscii()` when passing a string literal and
rely on compilers to optimize the `strlen(3)` call away.
Diffstat (limited to 'DiskIOMeter.c')
-rw-r--r-- | DiskIOMeter.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/DiskIOMeter.c b/DiskIOMeter.c index dd2e3c46..15ad5e54 100644 --- a/DiskIOMeter.c +++ b/DiskIOMeter.c @@ -97,10 +97,11 @@ static void DiskIOMeter_display(ATTR_UNUSED const Object* cast, RichString* out) } char buffer[16]; + int len; int color = cached_utilisation_diff > 40.0 ? METER_VALUE_NOTICE : METER_VALUE; - xSnprintf(buffer, sizeof(buffer), "%.1f%%", cached_utilisation_diff); - RichString_writeAscii(out, CRT_colors[color], buffer); + len = xSnprintf(buffer, sizeof(buffer), "%.1f%%", cached_utilisation_diff); + RichString_appendnAscii(out, CRT_colors[color], buffer, len); RichString_appendAscii(out, CRT_colors[METER_TEXT], " read: "); Meter_humanUnit(buffer, cached_read_diff, sizeof(buffer)); |