diff options
| author | Explorer09 <explorer09@gmail.com> | 2023-07-29 16:24:12 +0800 |
|---|---|---|
| committer | BenBE <BenBE@geshi.org> | 2023-08-18 12:52:28 +0200 |
| commit | b416433fbe7ccf935ad4e268396aa423143c2318 (patch) | |
| tree | 55a38c76f4f0091ed6b06d7369706bd2f1f6f61e /BatteryMeter.c | |
| parent | c6fd64fce8502a4e557711abe9fee394763ac52c (diff) | |
Replace isnan() with better comparisons (isgreater(), etc.)
The standard isnan() function is defined to never throw FP exceptions
even when the argument is a "signaling" NaN. This makes isnan() more
expensive than (x != x) expression unless the compiler flag
'-fno-signaling-nans' is given.
Introduce functions isNaN(), isNonnegative(), isPositive(),
sumPositiveValues() and compareRealNumbers(), and replace isnan() in
htop's codebase with the new functions. These functions utilize
isgreater() and isgreaterequal() comparisons, which do not throw FP
exceptions on "quiet" NaNs, which htop uses extensively.
With isnan() removed, there is no need to suppress the warning
'-Wno-c11-extensions' in FreeBSD. Remove the code from 'configure.ac'.
Signed-off-by: Kang-Che Sung <explorer09@gmail.com>
Diffstat (limited to 'BatteryMeter.c')
| -rw-r--r-- | BatteryMeter.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/BatteryMeter.c b/BatteryMeter.c index 33d17b73..24b2e682 100644 --- a/BatteryMeter.c +++ b/BatteryMeter.c @@ -12,6 +12,7 @@ This meter written by Ian P. Hands (iphands@gmail.com, ihands@redhat.com). #include <math.h> #include "CRT.h" +#include "Macros.h" #include "Object.h" #include "Platform.h" #include "XUtils.h" @@ -27,7 +28,7 @@ static void BatteryMeter_updateValues(Meter* this) { Platform_getBattery(&percent, &isOnAC); - if (isnan(percent)) { + if (!isNonnegative(percent)) { this->values[0] = NAN; xSnprintf(this->txtBuffer, sizeof(this->txtBuffer), "N/A"); return; |