Fix GCC build warning in NetBSD 10main

The warning message is
"array subscript has type 'char' [-Wchar-subscripts]"

Fix this by casting to 'unsigned char' before passing any character to a
`<ctype.h>` function.

Also add an assertion to RichString_writeFromAscii() to ensure the
characters in the string are all in ASCII range.

Signed-off-by: Kang-Che Sung <explorer09@gmail.com>

1 files changed, 1 insertions, 1 deletions

diff --git a/Settings.c b/Settings.c
index 07b7e6a2..5913af27 100644
--- a/Settings.c
+++ b/Settings.c
@@ -233,7 +233,7 @@ static const char* toFieldName(Hashtable* columns, int id, bool* enabled) {
 }
 
 static int toFieldIndex(Hashtable* columns, const char* str) {
-   if (isdigit(str[0])) {
+   if (isdigit((unsigned char)str[0])) {
       // This "+1" is for compatibility with the older enum format.
       int id = atoi(str) + 1;
       if (toFieldName(columns, id, NULL)) {