From 9dea20e06847f930920406e6de539db32e2644e0 Mon Sep 17 00:00:00 2001 From: Explorer09 Date: Wed, 4 May 2016 13:39:26 +0800 Subject: Rename Meter.setValues() functions to updateValues() Rationale (copied from htop issue #471): The function name "setValues" is misleading. For most OOP (object- oriented programming) contexts, setXXX functions mean they will change some member variables of an object into something specified in function arguments. But in the *Meter_setValues() case, the new values are not from the arguments, but from a hard-coded source. The caller is not supposed to change the values[] to anything it likes, but rather to "update" the values from the source. Hence, updateValues is a better name for this family of functions. --- SwapMeter.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'SwapMeter.c') diff --git a/SwapMeter.c b/SwapMeter.c index 476c4240..1406d6fb 100644 --- a/SwapMeter.c +++ b/SwapMeter.c @@ -24,7 +24,7 @@ int SwapMeter_attributes[] = { SWAP }; -static void SwapMeter_setValues(Meter* this, char* buffer, int size) { +static void SwapMeter_updateValues(Meter* this, char* buffer, int size) { int written; Platform_setSwapValues(this); @@ -54,7 +54,7 @@ MeterClass SwapMeter_class = { .delete = Meter_delete, .display = SwapMeter_display, }, - .setValues = SwapMeter_setValues, + .updateValues = SwapMeter_updateValues, .defaultMode = BAR_METERMODE, .maxItems = 1, .total = 100.0, -- cgit v1.2.3