From bea7f8e7afaab973d8086cc4b7d7978f06582f86 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Christian=20G=C3=B6ttsche?= <cgzones@googlemail.com>
Date: Fri, 12 Mar 2021 16:44:46 +0100
Subject: Process_compare: reorder checks

Check for result being 0 first, before checking if the result might be
negated, so we do not need to negate 0.
---
 Process.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

(limited to 'Process.c')

diff --git a/Process.c b/Process.c
index 58bd6a90..d80ad796 100644
--- a/Process.c
+++ b/Process.c
@@ -513,14 +513,11 @@ int Process_compare(const void* v1, const void* v2) {
 
    int result = Process_compareByKey(p1, p2, key);
 
-   if (Settings_getActiveDirection(settings) != 1)
-      result = -result;
-
    // Implement tie-breaker (needed to make tree mode more stable)
    if (!result)
       return SPACESHIP_NUMBER(p1->pid, p2->pid);
 
-   return result;
+   return (Settings_getActiveDirection(settings) == 1) ? result : -result;
 }
 
 static uint8_t stateCompareValue(char state) {
-- 
cgit v1.2.3