From 1e806f9899600256cbcc540715261f461e11dd25 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christian=20G=C3=B6ttsche?= Date: Sun, 7 Mar 2021 15:31:41 +0100 Subject: RichString: do not unnecessarily clean whole buffer The local stack buffer does not need to be cleaned to zeros when - just initialized, cause the length is set to 0 and the first character is set to '\0', so all printing functions will safely stop - no further used, i.e. the variable goes out of scope --- Panel.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'Panel.c') diff --git a/Panel.c b/Panel.c index c43fafcd..69933aea 100644 --- a/Panel.c +++ b/Panel.c @@ -69,7 +69,7 @@ void Panel_done(Panel* this) { free(this->eventHandlerState); Vector_delete(this->items); FunctionBar_delete(this->defaultBar); - RichString_end(this->header); + RichString_delete(&this->header); } void Panel_setSelectionColor(Panel* this, ColorElements colorId) { @@ -287,7 +287,7 @@ void Panel_draw(Panel* this, bool force_redraw, bool focus, bool highlightSelect RichString_printoffnVal(item, y + line, x, scrollH, amt); if (item.highlightAttr) attrset(CRT_colors[RESET_COLOR]); - RichString_end(item); + RichString_delete(&item); line++; } while (line < h) { @@ -316,8 +316,8 @@ void Panel_draw(Panel* this, bool force_redraw, bool focus, bool highlightSelect RichString_printoffnVal(new, y + this->selected - first, x, scrollH, MINIMUM(newLen - scrollH, this->w)); attrset(CRT_colors[RESET_COLOR]); - RichString_end(new); - RichString_end(old); + RichString_delete(&new); + RichString_delete(&old); } if (focus && (this->needsRedraw || force_redraw || !this->wasFocus)) { -- cgit v1.2.3