From 8c653212c0e6d15997e4217a514301f5682a41c4 Mon Sep 17 00:00:00 2001 From: Hisham Muhammad Date: Sun, 18 Feb 2018 10:38:49 -0300 Subject: Replace size_t with int/void* union I was occasionally passing negative values to size_t. Plus, this better reflects the intent of the variant argument. Reported by Coverity: https://scan8.coverity.com/reports.htm#v13253/p10402/fileInstanceId=22093891&defectInstanceId=7543346&mergedDefectId=174179&fileStart=251&fileEnd=500 --- OpenFilesScreen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'OpenFilesScreen.c') diff --git a/OpenFilesScreen.c b/OpenFilesScreen.c index a772bbac..f18511bb 100644 --- a/OpenFilesScreen.c +++ b/OpenFilesScreen.c @@ -130,7 +130,7 @@ void OpenFilesScreen_scan(InfoScreen* this) { char** data = fdata->data.data; int lenN = data['n'] ? strlen(data['n']) : 0; int sizeEntry = 5 + 7 + 10 + 10 + 10 + lenN + 5 /*spaces*/ + 1 /*null*/; - char* entry = xMalloc(sizeEntry); + char entry[sizeEntry]; xSnprintf(entry, sizeEntry, "%5.5s %7.7s %10.10s %10.10s %10.10s %s", data['f'] ? data['f'] : "", data['t'] ? data['t'] : "", -- cgit v1.2.3