From 9dea20e06847f930920406e6de539db32e2644e0 Mon Sep 17 00:00:00 2001 From: Explorer09 Date: Wed, 4 May 2016 13:39:26 +0800 Subject: Rename Meter.setValues() functions to updateValues() Rationale (copied from htop issue #471): The function name "setValues" is misleading. For most OOP (object- oriented programming) contexts, setXXX functions mean they will change some member variables of an object into something specified in function arguments. But in the *Meter_setValues() case, the new values are not from the arguments, but from a hard-coded source. The caller is not supposed to change the values[] to anything it likes, but rather to "update" the values from the source. Hence, updateValues is a better name for this family of functions. --- CPUMeter.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'CPUMeter.c') diff --git a/CPUMeter.c b/CPUMeter.c index 4a945c0e..32bad049 100644 --- a/CPUMeter.c +++ b/CPUMeter.c @@ -55,7 +55,7 @@ static void CPUMeter_init(Meter* this) { Meter_setCaption(this, "Avg"); } -static void CPUMeter_setValues(Meter* this, char* buffer, int size) { +static void CPUMeter_updateValues(Meter* this, char* buffer, int size) { int cpu = this->param; if (cpu > this->pl->cpuCount) { snprintf(buffer, size, "absent"); @@ -215,7 +215,7 @@ MeterClass CPUMeter_class = { .delete = Meter_delete, .display = CPUMeter_display }, - .setValues = CPUMeter_setValues, + .updateValues = CPUMeter_updateValues, .defaultMode = BAR_METERMODE, .maxItems = CPU_METER_ITEMCOUNT, .total = 100.0, -- cgit v1.2.3