summaryrefslogtreecommitdiffstats
path: root/pcp/Platform.c
Commit message (Collapse)AuthorAgeFilesLines
* Early program termination only from main()Volodymyr Vasiutyk2021-10-311-11/+14
|
* Update license headers to explicitly say GPLv2+Daniel Lange2021-09-221-1/+1
|
* Add completion handling for dynamic meters and columnsNathan Scott2021-09-031-0/+8
| | | | | | | Be sure to free dynamic memory allocated for meters and columns strings, no-op on platforms other than pcp. Closes #774
* Add combined memory and swap meterChristian Göttsche2021-08-171-0/+2
| | | | Closes: #699
* PCP: ensure unsigned types used throughout CPU count detectionNathan Scott2021-08-171-4/+4
| | | | | | | This cannot be negative in these code locations, but for the purposes of static checking like Coverity scan make it clear and used the same unsigned type as ProcessList.h for the CPU count variable (matching PL activeCPUs and existingCPUs).
* PCP: PCPMetric.[ch] MdouleSohaib2021-08-161-223/+51
| | | | | Split the PCP Metric API (functions `Metric_*`) into their own module. as @BenBE suggested.
* Merge branch 'dynamic-columns' of https://github.com/smalinux/htop into ↵Nathan Scott2021-08-131-20/+58
|\ | | | | | | smalinux-dynamic-columns
| * PCP: support for 'dynamic columns' added at runtimeSohaib Mohamed2021-08-131-20/+58
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Implements support for arbitrary Performance Co-Pilot metrics with per-process instance domains to form new htop columns. The column-to-metric mappings are setup using configuration files which will be documented via man pages as part of a follow-up commit. We provide an initial set of column configurations so as to provide new capabilities to pcp-htop: including configs for containers, open fd counts, scheduler run queue time, tcp/udp bytes/calls sent/recv, delay acct, virtual machine guests, detailed virtual memory, swap. Note there is a change to the configuration file path resolution algorithm introduced for 'dynamic meters'. First, look in any custom PCP_HTOP_DIR location. Then iterate, in priority order, users home directory, then local sysadmins files in /etc/pcp/htop, then readonly configuration files below /usr/share/pcp/htop. This final location becomes the preferred place for our own shipped meter and column files. The Settings file (htoprc) writing code is updated to not using the numeric identifier for dynamic columns. The same strategy used for dynamic meters is used here where we write Dynamic(name) so the name can be setup once more at start. Regular (static) columns writing to htoprc - i.e. numerically indexed - is unchanged.
* | Add columns for process autogroup identifier and nice valueNathan Scott2021-08-091-0/+2
|/ | | | | | | | | | | | Adds AGRP (autogroup) and ANI (autogroup nice) columns that report the information from /proc/PID/autogroup, as well as handlers for '{' and '}' to change the autogroup nice value. This is guarded by /proc/sys/kernel/sched_autogroup_enabled such that sampling and/or changing values wont be attempted unless the kernel feature is enabled. Fixes: #720
* PCP: use the correct metric for shared memory calculationsNathan Scott2021-07-291-1/+1
|
* Code indentationBenny Baumann2021-07-151-5/+5
|
* Remove unnecessary include files from PCPDynamicMeter.cNathan Scott2021-07-091-10/+10
| | | | | Also resolve a few unintended style guide transgressions in the PCP platform code.
* Add more defensive checks to PCP paths if sampling failsNathan Scott2021-07-071-2/+9
|
* Add a new DynamicMeter class for runtime Meter extensionNathan Scott2021-07-071-9/+43
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit is based on exploratory work by Sohaib Mohamed. The end goal is two-fold - to support addition of Meters we build via configuration files for both the PCP platform and for scripts ( https://github.com/htop-dev/htop/issues/526 ) Here, we focus on generic code and the PCP support. A new class DynamicMeter is introduced - it uses the special case 'param' field handling that previously was used only by the CPUMeter, such that every runtime-configured Meter is given a unique identifier. Unlike with the CPUMeter this is used internally only. When reading/writing to htoprc instead of CPU(N) - where N is an integer param (CPU number) - we use the string name for each meter. For example, if we have a configuration for a DynamicMeter for some Redis metrics, we might read and write "Dynamic(redis)". This identifier is subsequently matched (back) up to the configuration file so we're able to re-create arbitrary user configurations. The PCP platform configuration file format is fairly simple. We expand configs from several directories, including the users homedir alongside htoprc (below htop/meters/) and also /etc/pcp/htop/meters. The format will be described via a new pcp-htop(5) man page, but its basically ini-style and each Meter has one or more metric expressions associated, as well as specifications for labels, color and so on via a dot separated notation for individual metrics within the Meter. A few initial sample configuration files are provided below ./pcp/meters that give the general idea. The PCP "derived" metric specification - see pmRegisterDerived(3) - is used as the syntax for specifying metrics in PCP DynamicMeters.
* Fix a PCP diagnostics typo, add missing pmFreeResult null check.Nathan Scott2021-06-131-2/+3
|
* Resolve a couple of recent memory leaks in pcp-htopNathan Scott2021-06-131-0/+6
| | | | Makes the pcp-htop binary valgrind-clean once more.
* Update platform-specific header includes to use pcp paths.Nathan Scott2021-06-091-3/+3
| | | | Resolves a couple of remaining review notes from @BenBE.
* Update the PCP platform to use common Process fields and codeNathan Scott2021-06-091-0/+2
| | | | | | | Remove code now that we have common platform-independent command line wrangling (thanks BenBE!). Add PCP platform support for a handful of other recently arriving odds and ends - ELAPSED time, CWD, and so on.
* Various code tidyups based on review commentary from BenBENathan Scott2021-06-091-2/+4
|
* Resolve some Coverity scan misfires in PCP platform codeNathan Scott2021-06-091-37/+31
|
* Remove dynamic allocation of PCP metric atomvalues expansionNathan Scott2021-06-091-7/+0
| | | | This is no longer used and confuses Coverity scans, drop it.
* Add time handling interfaces for the pcp platformNathan Scott2021-06-091-10/+42
| | | | Related to https://github.com/htop-dev/htop/pull/574
* Implement command line and environment handling for pcp htop.Nathan Scott2021-06-091-3/+61
|
* Implement shared memory support on the PCP platformNathan Scott2021-06-091-10/+10
| | | | Uses the mem.util.shared metric (Shmem from meminfo).
* Update PCP platform to use the old hostname API callNathan Scott2021-06-091-1/+2
| | | | Fixes CI builds which are on an old version of PCP.
* Update PCP platform to match latest API changesNathan Scott2021-06-091-15/+85
| | | | | | Updates for recent NetworkIO Meter changes, adds support for the SysArch and HostName Meters. The SysArch change is based on work originally by Sohaib Mohamed.
* Ensure PCP platform ZramMeter always uses initialized dataNathan Scott2021-06-091-3/+5
|
* Fix PCP ZramMeter in presense of missing zram metricsSohaib2021-06-091-0/+3
|
* Add ZFS ARC statistics and meters to the PCP platformSohaib2021-06-091-1/+35
|
* Add a platform for Performance Co-Pilot (PCP) metricsNathan Scott2021-06-091-0/+687
This introduces an initial platform for extracting metrics using the PCP performance metrics API - PMAPI(3). It can be used via the --enable-pcp=yes configure option. So far I've added support for live localhost metrics only, and only using pre-defined metrics already found in htop. If available, all sampling is performed by pmcd(1) - else, we fallback to htop doing the metric sampling itself (all below the PMAPI). When pmcd is used, it may be configured to run children with elevated privileges, so htop does not need to be setuid (authentication with pmcd is available). Additionally, the PMAPI allows us to support archives (for historical analysis and for automated regression tests in htop). We'll need platform-specific command line argument additions, which isn't yet feasible in htop (not difficult to add though). The goal of this first version is minimal impact in terms of modifying the htop codebase, to introduce key ideas in PCP (metric namespace, metadata, APIs and so on) and give us something to discuss, experiment with and build on.

© 2014-2024 Faster IT GmbH | imprint | privacy policy