| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
| |
These allocations were converted to use xMalloc et al. and no longer
need error checks.
|
| |\
| |
| |
| | |
juanfra684-openbsd-mem-used
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Namely:
o use malloc where an xCalloc slipped in
o safeguard against an empty arg list - I don't think it's possible,
but it would be potentially exploitable
o we need to initialize the arg string to an empty string because we no
longer use strlcpy(3)
o annotate a tricky use of strlcpy(3)'s truncation
|
| |/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Including:
o set *basenameEnd even in error cases (FreeBSD probably needs this)
o use kvm_openfiles(3) rather than kvm_open(3) so that we can report
errors (as with FreeBSD)
o sanify the process argument list creation by using strlcat(3)
o drop the pageSizeKb variable and use the PAGE_SIZE_KB macro directly,
as the page size can't change anyway
o clean up a few macros, add MINIMUM() and MAXIMUM() (should be
mirrored to FreeBSD)
o fix some syntax
o add some useful comments
|
| |\ |
|
| | | |
|
| |/ |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With the CLAMP macro replacing the combination of MIN and MAX, we will
have at least two advantages:
1. It's more obvious semantically.
2. There are no more mixes of confusing uses like MIN(MAX(a,b),c) and
MAX(MIN(a,b),c) and MIN(a,MAX(b,c)) appearing everywhere. We unify
the 'clamping' with a single macro.
Note that the behavior of this CLAMP macro is different from
the combination `MAX(low,MIN(x,high))`.
* This CLAMP macro expands to two comparisons instead of three from
MAX and MIN combination. In theory, this makes the code slightly
smaller, in case that (low) or (high) or both are computed at
runtime, so that compilers cannot optimize them. (The third
comparison will matter if (low)>(high); see below.)
* CLAMP has a side effect, that if (low)>(high) it will produce weird
results. Unlike MIN & MAX which will force either (low) or (high) to
win. No assertion of ((low)<=(high)) is done in this macro, for now.
This CLAMP macro is implemented like described in glib
<http://developer.gnome.org/glib/stable/glib-Standard-Macros.html>
and does not handle weird uses like CLAMP(a++, low++, high--) .
|
| |\ |
|
| | |
| |
| |
| | |
Suggested by Hisham.
|
| | |
| |
| |
| | |
I think this leak may still exist in the FreeBSD port.
|
| | |\
| | |
| | | |
OpenBSD fixes and updates
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This is what OpenBSD's top(1) does when the libkvm call fails, and it's
a good idea.
This commit also fixes process name construction. The space was being
written one character too far.
|
| | | |
| | |
| | |
| | | |
Even when they're constant, as is the case for zombie processes.
|
| | | |
| | |
| | |
| | | |
Pointed out by Michael Reed.
|
| | | |
| | |
| | |
| | | |
So that we can see errno. Pointed out by Michael Reed.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
I forgot how awful the process name logic was. It was an initial hack to
get it running, and I forgot to clean it up.
I also had to change a few includes and error function uses.
|
| | |/ |
|
| |/
|
|
| |
- currently implemented for darwin and linux
|
| |\
| |
| | |
OpenBSD port updates and error exit improvements
|
| | |
| |
| |
| | |
err.h functions corrupts the terminal when using curses.
|
| | | |
|
| | | |
|
| | |
| |
| |
| | |
utilization value
|
| | |
| |
| |
| | |
Closes #293.
|
| |/ |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
