diff options
| author | Hisham Muhammad <hisham@gobolinux.org> | 2017-07-27 16:07:50 -0300 |
|---|---|---|
| committer | Hisham Muhammad <hisham@gobolinux.org> | 2017-07-27 16:07:50 -0300 |
| commit | 09e241fb1271021e3615512debd3136891547562 (patch) | |
| tree | 8245b6084607a34185cfa7d3d45f5228937020f1 /freebsd | |
| parent | 3975e9ce5cba0e3972b2ddab28c198e000441501 (diff) | |
Security review: check results of snprintf.
Calls marked with xSnprintf shouldn't fail.
Abort program cleanly if any of them does.
Diffstat (limited to 'freebsd')
| -rw-r--r-- | freebsd/FreeBSDProcess.c | 4 | ||||
| -rw-r--r-- | freebsd/FreeBSDProcessList.c | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/freebsd/FreeBSDProcess.c b/freebsd/FreeBSDProcess.c index 851a0ef4..f81fadf5 100644 --- a/freebsd/FreeBSDProcess.c +++ b/freebsd/FreeBSDProcess.c @@ -117,9 +117,9 @@ void FreeBSDProcess_writeField(Process* this, RichString* str, ProcessField fiel int n = sizeof(buffer) - 1; switch ((int) field) { // add FreeBSD-specific fields here - case JID: snprintf(buffer, n, Process_pidFormat, fp->jid); break; + case JID: xSnprintf(buffer, n, Process_pidFormat, fp->jid); break; case JAIL:{ - snprintf(buffer, n, "%-11s ", fp->jname); break; + xSnprintf(buffer, n, "%-11s ", fp->jname); break; if (buffer[11] != '\0') { buffer[11] = ' '; buffer[12] = '\0'; diff --git a/freebsd/FreeBSDProcessList.c b/freebsd/FreeBSDProcessList.c index c0cb06b1..9fef324a 100644 --- a/freebsd/FreeBSDProcessList.c +++ b/freebsd/FreeBSDProcessList.c @@ -398,7 +398,7 @@ char* FreeBSDProcessList_readJailName(struct kinfo_proc* kproc) { jid = jail_get(jiov, 6, 0); if (jid < 0) { if (!jail_errmsg[0]) - snprintf(jail_errmsg, JAIL_ERRMSGLEN, "jail_get: %s", strerror(errno)); + xSnprintf(jail_errmsg, JAIL_ERRMSGLEN, "jail_get: %s", strerror(errno)); return NULL; } else if (jid == kproc->ki_jid) { jname = xStrdup(jnamebuf); |