diff options
author | Hisham Muhammad <hisham@gobolinux.org> | 2017-07-27 16:07:50 -0300 |
---|---|---|
committer | Hisham Muhammad <hisham@gobolinux.org> | 2017-07-27 16:07:50 -0300 |
commit | 09e241fb1271021e3615512debd3136891547562 (patch) | |
tree | 8245b6084607a34185cfa7d3d45f5228937020f1 /Header.c | |
parent | 3975e9ce5cba0e3972b2ddab28c198e000441501 (diff) |
Security review: check results of snprintf.
Calls marked with xSnprintf shouldn't fail.
Abort program cleanly if any of them does.
Diffstat (limited to 'Header.c')
-rw-r--r-- | Header.c | 6 |
1 files changed, 3 insertions, 3 deletions
@@ -91,9 +91,9 @@ void Header_writeBackToSettings(const Header* this) { Meter* meter = (Meter*) Vector_get(vec, i); char* name = xCalloc(64, sizeof(char)); if (meter->param) { - snprintf(name, 63, "%s(%d)", As_Meter(meter)->name, meter->param); + xSnprintf(name, 63, "%s(%d)", As_Meter(meter)->name, meter->param); } else { - snprintf(name, 63, "%s", As_Meter(meter)->name); + xSnprintf(name, 63, "%s", As_Meter(meter)->name); } colSettings->names[i] = name; colSettings->modes[i] = meter->mode; @@ -155,7 +155,7 @@ char* Header_readMeterName(Header* this, int i, int column) { strncpy(name, Meter_name(meter), nameLen); name[nameLen] = '\0'; if (meter->param) - snprintf(name + nameLen, len - nameLen, "(%d)", meter->param); + xSnprintf(name + nameLen, len - nameLen, "(%d)", meter->param); return name; } |