diff options
| author | Christian Göttsche <cgzones@googlemail.com> | 2020-10-05 18:27:55 +0200 |
|---|---|---|
| committer | cgzones <cgzones@googlemail.com> | 2020-10-06 11:17:23 +0200 |
| commit | ad3acfc847e9d54f07a0684c19181d5f4c28fee4 (patch) | |
| tree | 7c014fd06e703281003b2277f700e867a7512af4 /ColumnsPanel.c | |
| parent | e9fa290019ad16e7909555e39830dd226115dfaf (diff) | |
Handle Panel_getSelected() returning NULL
Found by compiling with LTO:
ColumnsPanel.c: In function ‘ColumnsPanel_eventHandler’:
ColumnsPanel.c:46:59: error: potential null pointer dereference [-Werror=null-dereference]
46 | ((ListItem*)Panel_getSelected(super))->moving = this->moving;
| ^
AvailableColumnsPanel.c: In function ‘AvailableColumnsPanel_eventHandler’:
AvailableColumnsPanel.c:31:8: error: potential null pointer dereference [-Werror=null-dereference]
31 | int key = ((ListItem*) Panel_getSelected(super))->key;
| ^
AvailableMetersPanel.c: In function ‘AvailableMetersPanel_eventHandler’:
AvailableMetersPanel.c:40:24: error: potential null pointer dereference [-Werror=null-dereference]
40 | int param = selected->key & 0xff;
| ^
linux/IOPriorityPanel.c: In function ‘IOPriorityPanel_getIOPriority’:
linux/IOPriorityPanel.c:37:11: error: potential null pointer dereference [-Werror=null-dereference]
37 | return (IOPriority) ( ((ListItem*) Panel_getSelected(this))->key );
| ^
Diffstat (limited to 'ColumnsPanel.c')
| -rw-r--r-- | ColumnsPanel.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/ColumnsPanel.c b/ColumnsPanel.c index d7132e18..8328d15e 100644 --- a/ColumnsPanel.c +++ b/ColumnsPanel.c @@ -43,7 +43,9 @@ static HandlerResult ColumnsPanel_eventHandler(Panel* super, int ch) { if (selected < size - 1) { this->moving = !(this->moving); Panel_setSelectionColor(super, this->moving ? CRT_colors[PANEL_SELECTION_FOLLOW] : CRT_colors[PANEL_SELECTION_FOCUS]); - ((ListItem*)Panel_getSelected(super))->moving = this->moving; + ListItem* selectedItem = (ListItem*) Panel_getSelected(super); + if (selectedItem) + selectedItem->moving = this->moving; result = HANDLED; } break; |