summaryrefslogtreecommitdiffstats
path: root/AvailableMetersPanel.c
diff options
context:
space:
mode:
authorChristian Göttsche <cgzones@googlemail.com>2020-10-05 18:27:55 +0200
committercgzones <cgzones@googlemail.com>2020-10-06 11:17:23 +0200
commitad3acfc847e9d54f07a0684c19181d5f4c28fee4 (patch)
tree7c014fd06e703281003b2277f700e867a7512af4 /AvailableMetersPanel.c
parente9fa290019ad16e7909555e39830dd226115dfaf (diff)
Handle Panel_getSelected() returning NULL
Found by compiling with LTO: ColumnsPanel.c: In function ‘ColumnsPanel_eventHandler’: ColumnsPanel.c:46:59: error: potential null pointer dereference [-Werror=null-dereference] 46 | ((ListItem*)Panel_getSelected(super))->moving = this->moving; | ^ AvailableColumnsPanel.c: In function ‘AvailableColumnsPanel_eventHandler’: AvailableColumnsPanel.c:31:8: error: potential null pointer dereference [-Werror=null-dereference] 31 | int key = ((ListItem*) Panel_getSelected(super))->key; | ^ AvailableMetersPanel.c: In function ‘AvailableMetersPanel_eventHandler’: AvailableMetersPanel.c:40:24: error: potential null pointer dereference [-Werror=null-dereference] 40 | int param = selected->key & 0xff; | ^ linux/IOPriorityPanel.c: In function ‘IOPriorityPanel_getIOPriority’: linux/IOPriorityPanel.c:37:11: error: potential null pointer dereference [-Werror=null-dereference] 37 | return (IOPriority) ( ((ListItem*) Panel_getSelected(this))->key ); | ^
Diffstat (limited to 'AvailableMetersPanel.c')
-rw-r--r--AvailableMetersPanel.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/AvailableMetersPanel.c b/AvailableMetersPanel.c
index 604a6891..f5e59218 100644
--- a/AvailableMetersPanel.c
+++ b/AvailableMetersPanel.c
@@ -36,7 +36,10 @@ static HandlerResult AvailableMetersPanel_eventHandler(Panel* super, int ch) {
AvailableMetersPanel* this = (AvailableMetersPanel*) super;
Header* header = this->header;
- ListItem* selected = (ListItem*) Panel_getSelected(super);
+ const ListItem* selected = (ListItem*) Panel_getSelected(super);
+ if (!selected)
+ return IGNORED;
+
int param = selected->key & 0xff;
int type = selected->key >> 16;
HandlerResult result = IGNORED;

© 2014-2024 Faster IT GmbH | imprint | privacy policy