diff options
| author | Christian Göttsche <cgzones@googlemail.com> | 2020-10-05 18:27:55 +0200 |
|---|---|---|
| committer | cgzones <cgzones@googlemail.com> | 2020-10-06 11:17:23 +0200 |
| commit | ad3acfc847e9d54f07a0684c19181d5f4c28fee4 (patch) | |
| tree | 7c014fd06e703281003b2277f700e867a7512af4 /AvailableColumnsPanel.c | |
| parent | e9fa290019ad16e7909555e39830dd226115dfaf (diff) | |
Handle Panel_getSelected() returning NULL
Found by compiling with LTO:
ColumnsPanel.c: In function ‘ColumnsPanel_eventHandler’:
ColumnsPanel.c:46:59: error: potential null pointer dereference [-Werror=null-dereference]
46 | ((ListItem*)Panel_getSelected(super))->moving = this->moving;
| ^
AvailableColumnsPanel.c: In function ‘AvailableColumnsPanel_eventHandler’:
AvailableColumnsPanel.c:31:8: error: potential null pointer dereference [-Werror=null-dereference]
31 | int key = ((ListItem*) Panel_getSelected(super))->key;
| ^
AvailableMetersPanel.c: In function ‘AvailableMetersPanel_eventHandler’:
AvailableMetersPanel.c:40:24: error: potential null pointer dereference [-Werror=null-dereference]
40 | int param = selected->key & 0xff;
| ^
linux/IOPriorityPanel.c: In function ‘IOPriorityPanel_getIOPriority’:
linux/IOPriorityPanel.c:37:11: error: potential null pointer dereference [-Werror=null-dereference]
37 | return (IOPriority) ( ((ListItem*) Panel_getSelected(this))->key );
| ^
Diffstat (limited to 'AvailableColumnsPanel.c')
| -rw-r--r-- | AvailableColumnsPanel.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/AvailableColumnsPanel.c b/AvailableColumnsPanel.c index e605ae52..fd247af0 100644 --- a/AvailableColumnsPanel.c +++ b/AvailableColumnsPanel.c @@ -28,7 +28,6 @@ static void AvailableColumnsPanel_delete(Object* object) { static HandlerResult AvailableColumnsPanel_eventHandler(Panel* super, int ch) { AvailableColumnsPanel* this = (AvailableColumnsPanel*) super; - int key = ((ListItem*) Panel_getSelected(super))->key; HandlerResult result = IGNORED; switch(ch) { @@ -36,6 +35,11 @@ static HandlerResult AvailableColumnsPanel_eventHandler(Panel* super, int ch) { case KEY_ENTER: case KEY_F(5): { + const ListItem* selected = (ListItem*) Panel_getSelected(super); + if (!selected) + break; + + int key = selected->key; int at = Panel_getSelectedIndex(this->columns); Panel_insert(this->columns, at, (Object*) ListItem_new(Process_fields[key].name, key)); Panel_setSelected(this->columns, at+1); |