diff options
author | Nathan Scott <natoscott@users.noreply.github.com> | 2021-08-17 15:42:10 +1000 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-08-17 15:42:10 +1000 |
commit | d5ff5c48a889c1eab6e3792d3f5ca1566cf05491 (patch) | |
tree | 0b7093afd5d7846f86b1e317c0022130ca66e42e | |
parent | c7f634ec218da6bdb3bab9e9cd6fa7b2df3fcea8 (diff) |
Apply suggestions from code review
Co-authored-by: BenBE <BenBE@geshi.org>
-rw-r--r-- | Action.c | 2 | ||||
-rw-r--r-- | pcp/PCPDynamicColumn.c | 2 |
2 files changed, 2 insertions, 2 deletions
@@ -174,7 +174,7 @@ static Htop_Reaction actionSetSortColumn(State* st) { char* name = NULL; if (fields[i] >= LAST_PROCESSFIELD) { DynamicColumn* column = Hashtable_get(dynamicColumns, fields[i]); - if (column == NULL) + if (!column) continue; name = xStrdup(column->caption ? column->caption : column->name); } else { diff --git a/pcp/PCPDynamicColumn.c b/pcp/PCPDynamicColumn.c index 4051e101..3c4e6797 100644 --- a/pcp/PCPDynamicColumn.c +++ b/pcp/PCPDynamicColumn.c @@ -287,7 +287,7 @@ void PCPDynamicColumn_writeField(PCPDynamicColumn* this, const Process* proc, Ri int PCPDynamicColumn_compareByKey(const PCPProcess* p1, const PCPProcess* p2, ProcessField key) { const PCPDynamicColumn* column = Hashtable_get(p1->super.processList->dynamicColumns, key); - if (column == NULL) + if (!column) return -1; size_t metric = column->id; |