diff options
author | Christian Göttsche <cgzones@googlemail.com> | 2020-09-12 18:14:39 +0200 |
---|---|---|
committer | Christian Göttsche <cgzones@googlemail.com> | 2020-09-12 18:14:39 +0200 |
commit | d5eb72e64d2fbacb2b7045a07468b6bb1b8435a2 (patch) | |
tree | af5adc7ca6d73acf92b397ffc580444eba4fa012 | |
parent | cd55cfd6d263a89bbaf401481ea6bd6a5dd8f110 (diff) |
Drop always true condition
`env` is allocated by checked allocation functions and can not be NULL.
This checks confuses clang analyzer and causes a null-dereference
warning on `env[size-1]`.
-rw-r--r-- | linux/Platform.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/linux/Platform.c b/linux/Platform.c index ffe5c5c2..e82d8f88 100644 --- a/linux/Platform.c +++ b/linux/Platform.c @@ -237,7 +237,7 @@ char* Platform_getProcessEnv(pid_t pid) { if (fd) { size_t capacity = 4096, size = 0, bytes; env = xMalloc(capacity); - while (env && (bytes = fread(env+size, 1, capacity-size, fd)) > 0) { + while ((bytes = fread(env+size, 1, capacity-size, fd)) > 0) { size += bytes; capacity *= 2; env = xRealloc(env, capacity); |