summaryrefslogtreecommitdiffstats
path: root/bin/update-vuln
blob: e5847baa4bf6a3035478f7d2a6f49507f3e768b9 (plain) (blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
#!/usr/bin/env python
# -*- coding: utf-8 -*-
"""
  update-vuln - #1001453

  - mark a given released suite (stable/oldstable/LTS) as <not-affected>
    for a specific CVE ID
  - add a bug number to an existing CVE entry
  - add a NOTE: entry to an existing CVE

"""
#  Copyright 2021 Neil Williams <codehelp@debian.org>
#
#  This program is free software; you can redistribute it and/or modify
#  it under the terms of the GNU General Public License as published by
#  the Free Software Foundation; either version 2 of the License, or
#  (at your option) any later version.
#
#  This program is distributed in the hope that it will be useful,
#  but WITHOUT ANY WARRANTY; without even the implied warranty of
#  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
#  GNU General Public License for more details.
#
#  You should have received a copy of the GNU General Public License
#  along with this program; if not, write to the Free Software
#  Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
#  MA 02110-1301, USA.

import os
import argparse
import logging
import sys

import setup_paths  # noqa # pylint: disable=unused-import
from sectracker.parsers import (
    sourcepackages,
    PackageAnnotation,
    PackageBugAnnotation,
    StringAnnotation,
    Bug,
    cvelist,
    writecvelist,
)


class ParseUpdates:
    """
    Update a CVE with requested changes and produce a file for
    manual review and use with merge-cve-files.
    """

    def __init__(self):
        self.cves = []
        self.bugs = {}
        self.logger = logging.getLogger("update-vuln")
        self.logger.setLevel(logging.DEBUG)
        # console logging
        ch = logging.StreamHandler()
        ch.setLevel(logging.DEBUG)
        formatter = logging.Formatter("%(name)s - %(levelname)s - %(message)s")
        ch.setFormatter(formatter)
        self.logger.addHandler(ch)

    def _read_cvelist(self):
        os.chdir(os.path.dirname(os.path.dirname(os.path.realpath(__file__))))
        data, _ = cvelist("data/CVE/list")
        for cve in self.cves:
            for bug in data:
                if bug.header.name == cve:
                    self.bugs[cve] = bug

    def _add_annotation_after_line(self, cve, line, annotation):
        bug_list = list(self.bugs[cve].annotations)
        bug_list.append(annotation)
        return Bug(self.bugs[cve].file, self.bugs[cve].header, tuple(bug_list))

    def _replace_annotation_on_line(self, cve, line, mod_line):
        index = self.bugs[cve].annotations.index(line)
        bug_list = list(self.bugs[cve].annotations)
        bug_list[index] = mod_line
        return Bug(self.bugs[cve].file, self.bugs[cve].header, tuple(bug_list))

    def write_modified(self, modified, cve_file):
        if not modified:
            return
        if not isinstance(modified, list):
            return
        if os.path.exists(cve_file):
            self.logger.critical("%s already exists - appending", cve_file)
            return -1
        mods = []
        for cve in modified:
            self.logger.info(
                "Writing to ./%s with update for %s", cve_file, cve.header.name
            )
        with open(cve_file, "a") as snippet:
            writecvelist(modified, snippet)

    def mark_not_affected(self, suite, src):
        """
        Writes out a CVE file snippet with the filename:
        ./<cve>.list
        Fails if the file already exists.
        """
        release = suite
        if suite == "unstable" or suite == "sid":
            # special handling for unstable
            suite = None
            release = "unstable"
        modified = []
        cve = self.cves[0]
        cve_file = f"{cve}.list"
        for line in self.bugs[cve].annotations:
            if not isinstance(line, PackageAnnotation):
                continue  # skip notes etc.
            if line.release != suite:
                continue
            if line.package != src:
                continue
            # need to define the allowed changes
            # if fixed, version would need to be undone too.
            if line.kind == "not-affected":
                self.logger.info("Nothing to do for %s in %s.", cve, suite)
                return
            mod_line = line._replace(kind="not-affected")
            self.logger.info(
                "Modified %s for %s in %s to <not-affected>", cve, src, release
            )
            if mod_line.version:
                self.logger.info("Removing version %s", line.version)
                ver_line = mod_line
                mod_line = ver_line._replace(version=None)
            if mod_line.description:
                self.logger.info("Removing description %s", line.description)
                desc_line = mod_line
                mod_line = desc_line._replace(description=None)
            # removing a bug annotation is not covered, yet.
            mod_bug = self._replace_annotation_on_line(cve, line, mod_line)
            modified.append(mod_bug)
        self.write_modified(modified, cve_file)

    def add_note(self, note):
        """
        Writes out a CVE file snippet with the filename:
        ./<cve>.list
        Fails if the file already exists.
        """
        # use _add_annotation_after_line to add a line
        modified = []
        cve = self.cves[0]
        cve_file = f"{cve}.list"
        existing = [
            note.description
            for note in self.bugs[cve].annotations
            if isinstance(note, StringAnnotation)
        ]
        lines = [
            note.line
            for note in self.bugs[cve].annotations
            if isinstance(note, StringAnnotation)
        ]
        if note in existing:
            self.logger.info("Note already exists, ignoring")
            return
        new_note = StringAnnotation(line=0, type="NOTE", description=note)
        mod_bug = self._add_annotation_after_line(cve, 0, new_note)
        modified.append(mod_bug)
        self.write_modified(modified, cve_file)

    def add_bug_number(self, bug, itp=False):
        """
        Writes out a CVE file snippet with the filename:
        ./<cve>.list
        Fails if the file already exists.
        """
        # bugs only apply to unstable (or itp)
        modified = []
        cve = self.cves[0]
        cve_file = f"{cve}.list"
        existing = [
            pkg.flags
            for pkg in self.bugs[cve].annotations
            if isinstance(pkg, PackageAnnotation)
            if not pkg.release and pkg.kind != "removed"
        ]
        bugs = [bug for sublist in existing for bug in sublist]
        if bugs:
            self.logger.warning(
                "%s already has a bug annotation for unstable: %s", cve, bugs[0].bug
            )
            return -1
        pkgs = [
            pkg
            for pkg in self.bugs[cve].annotations
            if isinstance(pkg, PackageAnnotation)
            if not pkg.release and pkg.kind != "removed"
        ]
        if itp:
            # no useful entry will exist in pkgs
            new_flags = [PackageBugAnnotation(bug)]
            new_pkg = PackageAnnotation(
                0,
                "package",
                None,
                itp,
                "itp",
                None,
                None,
                new_flags,
            )
            others = []
        else:
            if not pkgs:
                self.logger.error("%s does not have a package annotation.", cve)
                return -1
            old_pkg = pkgs[0]
            if itp and old_pkg.kind == "fixed":
                self.logger.error(
                    "%s is already marked as <fixed> but --itp flag was set.", cve
                )
                return -3
            new_flags = [PackageBugAnnotation(bug)]
            new_pkg = PackageAnnotation(
                old_pkg.line,
                old_pkg.type,
                old_pkg.release,
                old_pkg.package,
                old_pkg.kind,
                old_pkg.version,
                old_pkg.description,
                new_flags,
            )
            others = [pkg for pkg in bug_list if pkg.line != old_pkg.line]
        bug_list = list(self.bugs[cve].annotations)
        # may need to retain the original order.
        new_list = [new_pkg] + others
        mod_bug = Bug(self.bugs[cve].file, self.bugs[cve].header, tuple(new_list))
        modified.append(mod_bug)
        self.write_modified(modified, cve_file)

    def load_cve(self, cve):
        self.logger.info("Loading data for %s...", cve)
        self.cves.append(cve)
        self._read_cvelist()


def main():
    """
    This script does NOT reparse the output file - create, review and
    merge ONE update at a time.
    (For some operations, check-new-issues may be more suitable).

    For example, --bug 100 --itp intended_pkg_name
    then, merge-cve-list, then:
    --note "URL:"
    """
    parser = argparse.ArgumentParser(
        description="Make a single update to specified CVE data as "
        "not-affected, add bug number or add a note",
        epilog="Data is written to a new <cve_number>.list "
        "file which can be used with './bin/merge-cve-files'. "
        "Make sure the output file is merged and removed before "
        "updating the same CVE again.",
    )

    required = parser.add_argument_group("Required arguments")
    required.add_argument("--cve", required=True, help="The CVE ID to update")

    affected = parser.add_argument_group(
        "Marking a CVE as not-affected - must use --src and --suite"
    )
    # needs to specify the src_package as well as suite to cope with removed etc.
    affected.add_argument("--src", help="Source package name in SUITE")
    affected.add_argument(
        "--suite", default="unstable", help="Mark the CVE as <not-affected> in SUITE"
    )

    buggy = parser.add_argument_group("Add a bug number to the CVE")
    buggy.add_argument("--number", help="Debian BTS bug number")
    buggy.add_argument(
        "--itp",
        metavar="SRC",
        help="Mark as an ITP bug for the specified source package name",
    )

    notes = parser.add_argument_group("Add a NOTE: entry to the CVE")
    notes.add_argument("--note", help="Content of the NOTE: entry to add to the CVE")

    args = parser.parse_args()
    parser = ParseUpdates()
    parser.load_cve(args.cve)

    if not parser.bugs:
        self.logger.critical("Unable to parse CVE ID %s", args.cve)
        return -1
    if args.src and args.suite:
        parser.mark_not_affected(args.suite, args.src)
    if args.note:
        parser.add_note(args.note)
    if args.number:
        # to set itp properly, the source package name also needs to be set.
        parser.add_bug_number(args.number, args.itp)
    return 0


if __name__ == "__main__":
    sys.exit(main())

© 2014-2024 Faster IT GmbH | imprint | privacy policy