From a07fab907f1ad57b4f03ebd695f47009a816ce57 Mon Sep 17 00:00:00 2001 From: Chris Lamb Date: Thu, 4 Aug 2016 17:49:15 +0000 Subject: lts-missing-uploads: Don't blow up on invalid version numbers in DLAs git-svn-id: svn+ssh://svn.debian.org/svn/secure-testing@43772 e39458fd-73e7-0310-bf30-c45bca0a0e42 --- bin/lts-missing-uploads.py | 25 +++++++++++++++++++------ 1 file changed, 19 insertions(+), 6 deletions(-) (limited to 'bin/lts-missing-uploads.py') diff --git a/bin/lts-missing-uploads.py b/bin/lts-missing-uploads.py index 462c904e19..0c8cbf9dd0 100755 --- a/bin/lts-missing-uploads.py +++ b/bin/lts-missing-uploads.py @@ -71,16 +71,29 @@ class LTSMissingUploads(object): sources = self.get_sources() for source, dla in sorted(dlas.items()): - version = sources[source] - - if Version(dla['version']) > Version(version): - self.warn("{}: DLA-{} announced version {} but LTS has {} <{}>".format( + try: + dla_version = Version(dla['version']) + except ValueError: + self.warn("{}: DLA-{} announced with invalid version: {} <{}>", source, dla['dla'], dla['version'], - version, dla['url'], - )) + ) + continue + + archive_version = Version(sources[source]) + + if dla_version <= archive_version: + continue + + self.warn("{}: DLA-{} announced version {} but LTS has {} <{}>", + source, + dla['dla'], + dla_version, + archive_version, + dla['url'], + ) return 0 -- cgit v1.2.3