From 9dea20e06847f930920406e6de539db32e2644e0 Mon Sep 17 00:00:00 2001 From: Explorer09 Date: Wed, 4 May 2016 13:39:26 +0800 Subject: Rename Meter.setValues() functions to updateValues() Rationale (copied from htop issue #471): The function name "setValues" is misleading. For most OOP (object- oriented programming) contexts, setXXX functions mean they will change some member variables of an object into something specified in function arguments. But in the *Meter_setValues() case, the new values are not from the arguments, but from a hard-coded source. The caller is not supposed to change the values[] to anything it likes, but rather to "update" the values from the source. Hence, updateValues is a better name for this family of functions. --- UptimeMeter.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'UptimeMeter.c') diff --git a/UptimeMeter.c b/UptimeMeter.c index 5e0a9e9a..d20c4797 100644 --- a/UptimeMeter.c +++ b/UptimeMeter.c @@ -17,7 +17,7 @@ int UptimeMeter_attributes[] = { UPTIME }; -static void UptimeMeter_setValues(Meter* this, char* buffer, int len) { +static void UptimeMeter_updateValues(Meter* this, char* buffer, int len) { int totalseconds = Platform_getUptime(); if (totalseconds == -1) { snprintf(buffer, len, "(unknown)"); @@ -49,7 +49,7 @@ MeterClass UptimeMeter_class = { .extends = Class(Meter), .delete = Meter_delete }, - .setValues = UptimeMeter_setValues, + .updateValues = UptimeMeter_updateValues, .defaultMode = TEXT_METERMODE, .maxItems = 1, .total = 100.0, -- cgit v1.2.3