From 1e806f9899600256cbcc540715261f461e11dd25 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christian=20G=C3=B6ttsche?= Date: Sun, 7 Mar 2021 15:31:41 +0100 Subject: RichString: do not unnecessarily clean whole buffer The local stack buffer does not need to be cleaned to zeros when - just initialized, cause the length is set to 0 and the first character is set to '\0', so all printing functions will safely stop - no further used, i.e. the variable goes out of scope --- RichString.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'RichString.c') diff --git a/RichString.c b/RichString.c index c4ecc258..558c7430 100644 --- a/RichString.c +++ b/RichString.c @@ -185,11 +185,11 @@ int RichString_findChar(const RichString* this, char c, int start) { #endif /* HAVE_LIBNCURSESW */ -void RichString_prune(RichString* this) { - if (this->chlen > RICHSTRING_MAXLEN) +void RichString_delete(RichString* this) { + if (this->chlen > RICHSTRING_MAXLEN) { free(this->chptr); - memset(this, 0, sizeof(RichString)); - this->chptr = this->chstr; + this->chptr = this->chstr; + } } void RichString_setAttr(RichString* this, int attrs) { -- cgit v1.2.3