From 09e241fb1271021e3615512debd3136891547562 Mon Sep 17 00:00:00 2001 From: Hisham Muhammad Date: Thu, 27 Jul 2017 16:07:50 -0300 Subject: Security review: check results of snprintf. Calls marked with xSnprintf shouldn't fail. Abort program cleanly if any of them does. --- Header.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'Header.c') diff --git a/Header.c b/Header.c index 07631058..e048ee55 100644 --- a/Header.c +++ b/Header.c @@ -91,9 +91,9 @@ void Header_writeBackToSettings(const Header* this) { Meter* meter = (Meter*) Vector_get(vec, i); char* name = xCalloc(64, sizeof(char)); if (meter->param) { - snprintf(name, 63, "%s(%d)", As_Meter(meter)->name, meter->param); + xSnprintf(name, 63, "%s(%d)", As_Meter(meter)->name, meter->param); } else { - snprintf(name, 63, "%s", As_Meter(meter)->name); + xSnprintf(name, 63, "%s", As_Meter(meter)->name); } colSettings->names[i] = name; colSettings->modes[i] = meter->mode; @@ -155,7 +155,7 @@ char* Header_readMeterName(Header* this, int i, int column) { strncpy(name, Meter_name(meter), nameLen); name[nameLen] = '\0'; if (meter->param) - snprintf(name + nameLen, len - nameLen, "(%d)", meter->param); + xSnprintf(name + nameLen, len - nameLen, "(%d)", meter->param); return name; } -- cgit v1.2.3