Avoid writing configuration to non-regular files

Check whether the configuration file (after symlink resolution) is
writable and is a regular file on htop startup, and only then, write the
configuration on exit.

Also permit reading when the legacy configuration file ("~/.htoprc") is
a symlink. Write the new configuration only when both the legacy file
and the new location are writable.

Thanks to Christian Göttsche (@cgzones) for providing the initial
version of the patch.

Fixes: #1426

Signed-off-by: Kang-Che Sung <explorer09@gmail.com>

1 files changed, 1 insertions, 0 deletions

diff --git a/Settings.h b/Settings.h
index de4e0096..b5bc8efd 100644
--- a/Settings.h
+++ b/Settings.h
@@ -55,6 +55,7 @@ typedef struct ScreenSettings_ {
 typedef struct Settings_ {
    char* filename;
    char* initialFilename;
+   bool writeConfig; /* whether to write the current settings on exit */
    int config_version;
    HeaderLayout hLayout;
    MeterColumnSetting* hColumns;