Explicitly check sscanf(3) and fscanf(3) return values

Compare the return value of sscanf(3) and fscanf(3) explicitly against
the expected number of parsed items and avoid implicit boolean
conversion.  Such an implicit conversion would treat EOF (-1) the same
as at least one item parsed successfully.

Reported by CodeQL.

1 files changed, 1 insertions, 1 deletions

diff --git a/Settings.c b/Settings.c
index a01e2494..815224be 100644
--- a/Settings.c
+++ b/Settings.c
@@ -240,7 +240,7 @@ static int toFieldIndex(Hashtable* columns, const char* str) {
    } else {
       // Dynamically-defined columns are always stored by-name.
       char dynamic[32] = {0};
-      if (sscanf(str, "Dynamic(%30s)", dynamic)) {
+      if (sscanf(str, "Dynamic(%30s)", dynamic) == 1) {
          char* end;
          if ((end = strrchr(dynamic, ')')) != NULL) {
             bool success;