summaryrefslogtreecommitdiffstats
path: root/RichString.h
diff options
context:
space:
mode:
authorExplorer09 <explorer09@gmail.com>2016-01-15 20:26:01 +0800
committerExplorer09 <explorer09@gmail.com>2016-01-15 20:26:01 +0800
commit6dae8108f8e6a8d3f4ccf3d92f8bb19d3933861a (patch)
tree7cb08e282337b483de387b68cf7e225eb359853f /RichString.h
parent195f5edbc8dd79267fa23feb5fda2a8be812abeb (diff)
Introduce CLAMP macro. Unify all MIN(MAX(a,b),c) uses.
With the CLAMP macro replacing the combination of MIN and MAX, we will have at least two advantages: 1. It's more obvious semantically. 2. There are no more mixes of confusing uses like MIN(MAX(a,b),c) and MAX(MIN(a,b),c) and MIN(a,MAX(b,c)) appearing everywhere. We unify the 'clamping' with a single macro. Note that the behavior of this CLAMP macro is different from the combination `MAX(low,MIN(x,high))`. * This CLAMP macro expands to two comparisons instead of three from MAX and MIN combination. In theory, this makes the code slightly smaller, in case that (low) or (high) or both are computed at runtime, so that compilers cannot optimize them. (The third comparison will matter if (low)>(high); see below.) * CLAMP has a side effect, that if (low)>(high) it will produce weird results. Unlike MIN & MAX which will force either (low) or (high) to win. No assertion of ((low)<=(high)) is done in this macro, for now. This CLAMP macro is implemented like described in glib <http://developer.gnome.org/glib/stable/glib-Standard-Macros.html> and does not handle weird uses like CLAMP(a++, low++, high--) .
Diffstat (limited to 'RichString.h')
-rw-r--r--RichString.h4
1 files changed, 0 insertions, 4 deletions
diff --git a/RichString.h b/RichString.h
index 04e468d9..796965ac 100644
--- a/RichString.h
+++ b/RichString.h
@@ -59,10 +59,6 @@ typedef struct RichString_ {
} RichString;
-#ifndef MIN
-#define MIN(a,b) ((a)<(b)?(a):(b))
-#endif
-
#define charBytes(n) (sizeof(CharType) * (n))
#define RichString_setLen(this, len) do{ if(len < RICHSTRING_MAXLEN && this->chlen < RICHSTRING_MAXLEN) { RichString_setChar(this,len,0); this->chlen=len; } else RichString_extendLen(this,len); }while(0)

© 2014-2024 Faster IT GmbH | imprint | privacy policy