diff options
| author | Explorer09 <explorer09@gmail.com> | 2016-05-04 13:39:26 +0800 |
|---|---|---|
| committer | Explorer09 <explorer09@gmail.com> | 2016-05-04 13:39:26 +0800 |
| commit | 9dea20e06847f930920406e6de539db32e2644e0 (patch) | |
| tree | 9fa1d0fcf5d166ad0b8fddb74ba541b0252d1727 /LoadAverageMeter.c | |
| parent | 2ea4bee66dfe496ee649ecb81245b70554774975 (diff) | |
Rename Meter.setValues() functions to updateValues()
Rationale (copied from htop issue #471):
The function name "setValues" is misleading. For most OOP (object-
oriented programming) contexts, setXXX functions mean they will change
some member variables of an object into something specified in
function arguments. But in the *Meter_setValues() case, the new values
are not from the arguments, but from a hard-coded source. The caller
is not supposed to change the values[] to anything it likes, but
rather to "update" the values from the source. Hence, updateValues is
a better name for this family of functions.
Diffstat (limited to 'LoadAverageMeter.c')
| -rw-r--r-- | LoadAverageMeter.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/LoadAverageMeter.c b/LoadAverageMeter.c index a5a04d32..54e517a8 100644 --- a/LoadAverageMeter.c +++ b/LoadAverageMeter.c @@ -20,7 +20,7 @@ int LoadAverageMeter_attributes[] = { int LoadMeter_attributes[] = { LOAD }; -static void LoadAverageMeter_setValues(Meter* this, char* buffer, int size) { +static void LoadAverageMeter_updateValues(Meter* this, char* buffer, int size) { Platform_getLoadAverage(&this->values[0], &this->values[1], &this->values[2]); snprintf(buffer, size, "%.2f/%.2f/%.2f", this->values[0], this->values[1], this->values[2]); } @@ -36,7 +36,7 @@ static void LoadAverageMeter_display(Object* cast, RichString* out) { RichString_append(out, CRT_colors[LOAD_AVERAGE_FIFTEEN], buffer); } -static void LoadMeter_setValues(Meter* this, char* buffer, int size) { +static void LoadMeter_updateValues(Meter* this, char* buffer, int size) { double five, fifteen; Platform_getLoadAverage(&this->values[0], &five, &fifteen); if (this->values[0] > this->total) { @@ -58,7 +58,7 @@ MeterClass LoadAverageMeter_class = { .delete = Meter_delete, .display = LoadAverageMeter_display, }, - .setValues = LoadAverageMeter_setValues, + .updateValues = LoadAverageMeter_updateValues, .defaultMode = TEXT_METERMODE, .maxItems = 3, .total = 100.0, @@ -75,7 +75,7 @@ MeterClass LoadMeter_class = { .delete = Meter_delete, .display = LoadMeter_display, }, - .setValues = LoadMeter_setValues, + .updateValues = LoadMeter_updateValues, .defaultMode = TEXT_METERMODE, .maxItems = 1, .total = 100.0, |